Closed
Conversation
|
5GB is huge for this docker image. It'll be better to use multi stages, have the first stage build the artifacts (both frontend with node and back end with golang) then copy them to the second stage(the release image) then the final container image will not contain everything used to build it. |
Author
|
Totally agree, that is not something I have ever done before but I might have time next week to figure it out |
Author
|
lol, it was muuuuch simpler then I thought |
Author
|
Closing this pull and will open a new one |
Author
|
Link to the new pull request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all the tools required for building OpenMaxUI I decided to do this inside a docker container, I decided to use ubuntu as a base image since I am familiar with it, it could probably be built as a lighter image inside alpine or something
This pull request includes the Dockerfile required for building the image and a docker compose file with an nginx reverse proxy to provide https access on port 443
Note: the initial build time is significant and the final docker image ends up being close to 5GB in size