Skip to content

Fix multi chain RMSD analysis#64

Open
hannahbaumann wants to merge 55 commits intomainfrom
fix_rmsd_multichain
Open

Fix multi chain RMSD analysis#64
hannahbaumann wants to merge 55 commits intomainfrom
fix_rmsd_multichain

Conversation

@hannahbaumann
Copy link
Contributor

@hannahbaumann hannahbaumann commented Dec 18, 2025

Fixes #30

@hannahbaumann hannahbaumann changed the title Fix multi chain RMSD analysis [WIP] Fix multi chain RMSD analysis Dec 18, 2025
@hannahbaumann hannahbaumann self-assigned this Dec 19, 2025
@hannahbaumann
Copy link
Contributor Author

Check if this works for triclinic boxes. From Irfan: There might also be code in MDAnalysis that does the math also working for triclinic boxes.

@hannahbaumann hannahbaumann marked this pull request as ready for review January 16, 2026 10:30
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (5260e3b) to head (73fe2ee).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   88.16%   89.32%   +1.16%     
==========================================
  Files           7        6       -1     
  Lines         338      328      -10     
==========================================
- Hits          298      293       -5     
+ Misses         40       35       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hannahbaumann hannahbaumann changed the title [WIP] Fix multi chain RMSD analysis Fix multi chain RMSD analysis Jan 28, 2026
center = self.central_ag.center_of_mass()
box = self.central_ag.dimensions[:3]
center = self.reference.center_of_mass()
box = triclinic_vectors(ts.dimensions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is great that it works with all boxes.

@IAlibay IAlibay self-assigned this Feb 2, 2026
nope = NoJump(prot)
minnie = Minimiser(prot, ligand)
# Unwrap all atoms
unwrap_tr = unwrap(prot)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I changed the NoJump to unwrap since NoJump only corrects the COM. Should we do the same for the ligand below? @IAlibay , do you know what was the reason for implementing this new NoJump transformation instead of using the MDanalysis unwrap?

@hannahbaumann
Copy link
Contributor Author

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analysis does not work properly for proteins with multiple chains

3 participants