Conversation
|
Check if this works for triclinic boxes. From Irfan: There might also be code in MDAnalysis that does the math also working for triclinic boxes. |
…e runners for the matrix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 88.16% 89.32% +1.16%
==========================================
Files 7 6 -1
Lines 338 328 -10
==========================================
- Hits 298 293 -5
+ Misses 40 35 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| center = self.central_ag.center_of_mass() | ||
| box = self.central_ag.dimensions[:3] | ||
| center = self.reference.center_of_mass() | ||
| box = triclinic_vectors(ts.dimensions) |
There was a problem hiding this comment.
Nice this is great that it works with all boxes.
| nope = NoJump(prot) | ||
| minnie = Minimiser(prot, ligand) | ||
| # Unwrap all atoms | ||
| unwrap_tr = unwrap(prot) |
There was a problem hiding this comment.
Here I changed the NoJump to unwrap since NoJump only corrects the COM. Should we do the same for the ligand below? @IAlibay , do you know what was the reason for implementing this new NoJump transformation instead of using the MDanalysis unwrap?
|
pre-commit.ci autofix |
Fixes #30