Draft
Conversation
Contributor
Author
|
pre-commit.ci autofix |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 95.34% 88.82% -6.52%
==========================================
Files 183 184 +1
Lines 15779 16422 +643
==========================================
- Hits 15044 14587 -457
- Misses 735 1835 +1100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
requested changes
Oct 29, 2025
Member
IAlibay
left a comment
There was a problem hiding this comment.
I strongly veto this addition, we can discuss when I'm back next week.
…atom-mapper' into feat/vendor-perses-atom-mapper
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
No API break detected ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation of this PR is that
persesis not really maintained upstream.Really the only part of
perseswe (optionally) use is the atom mapper and scorer.This part of the code has no new deps, which means that you can use the
persesatom mapper and scorer without installingperses(which brings in many unneeded deps).Fixes #1635
Checklist
newsentryDevelopers certificate of origin