Remove silent fallback in dbIP to surface decryption failures#1664
Closed
Remove silent fallback in dbIP to surface decryption failures#1664
Conversation
Merged
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP: Address feedback from review on PR T8
Remove silent fallback in dbIP to surface decryption failures
Feb 5, 2026
nmaguiar
requested changes
Feb 5, 2026
Collaborator
nmaguiar
left a comment
There was a problem hiding this comment.
Original behavior is intended "If decryption fails, return as string"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dbIPmethod was catching decryption exceptions and silently returning raw bytes as a string, making it impossible to distinguish successful decryption from failure. This masked errors until downstream YAML/JSON parsing, producing confusing error messages.Changes
throws Exceptionto method signature to propagate decryption errorsjs/owrap.oJob.js's_loadfunction)Decryption failures now surface immediately with clear error context rather than manifesting as downstream parsing errors.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.