Skip to content

Remove silent fallback in dbIP to surface decryption failures#1664

Closed
Copilot wants to merge 2 commits intot8from
copilot/sub-pr-1662-again
Closed

Remove silent fallback in dbIP to surface decryption failures#1664
Copilot wants to merge 2 commits intot8from
copilot/sub-pr-1662-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

The dbIP method was catching decryption exceptions and silently returning raw bytes as a string, making it impossible to distinguish successful decryption from failure. This masked errors until downstream YAML/JSON parsing, producing confusing error messages.

Changes

  • Removed try-catch wrapper that converted decryption failures into silent fallbacks
  • Added throws Exception to method signature to propagate decryption errors
  • Exception handling already exists in calling code (js/owrap.oJob.js's _load function)
// Before: silent fallback on decryption failure
public String dbIP(Object aBytes) {
    // ...
    try {
        return AFBase.decryptBytes2String(aBytes, null);
    } catch (Exception e) {
        return new String((byte[]) aBytes);  // Masks the error
    }
}

// After: explicit failure propagation
public String dbIP(Object aBytes) throws Exception {
    // ...
    return AFBase.decryptBytes2String(aBytes, null);
}

Decryption failures now surface immediately with clear error context rather than manifesting as downstream parsing errors.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP: Address feedback from review on PR T8 Remove silent fallback in dbIP to surface decryption failures Feb 5, 2026
Copy link
Collaborator

@nmaguiar nmaguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original behavior is intended "If decryption fails, return as string"

Copilot AI requested a review from nmaguiar February 5, 2026 12:34
@nmaguiar nmaguiar closed this Feb 5, 2026
@nmaguiar nmaguiar deleted the copilot/sub-pr-1662-again branch February 5, 2026 12:35
Copilot stopped work on behalf of nmaguiar due to an error February 5, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants