Remove private arguments from params before job execution#57
Open
Remove private arguments from params before job execution#57
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds parameter sanitization to prevent private arguments (those with keys starting with underscore) from being passed to job functions during execution. The changes ensure that internal or sensitive data is filtered out before job invocation.
Changes:
- Added logic to remove private arguments from
params.argumentsandparams.inputbefore job execution in thetools/callhandler
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but important change to the job execution logic in
oJobMCP.yaml. Now, before invoking a job function, any private arguments (those whose keys start with an underscore) are removed from bothparams.argumentsandparams.input. This helps prevent internal or sensitive data from being passed to job functions unintentionally._) are now deleted fromparams.argumentsandparams.inputbefore job execution to avoid leaking internal data.