Skip to content

Split ECR include/exclude filters by newline#96

Draft
nmaguiar wants to merge 1 commit intomainfrom
codex/add-mcp-aws-ecr-server-configuration
Draft

Split ECR include/exclude filters by newline#96
nmaguiar wants to merge 1 commit intomainfrom
codex/add-mcp-aws-ecr-server-configuration

Conversation

@nmaguiar
Copy link
Contributor

@nmaguiar nmaguiar commented Feb 4, 2026

Motivation

  • The ECR MCP previously treated includere/excludere string inputs as a single pattern which blocked newline-delimited lists of regexes; this change accepts newline-separated regex lists per inline feedback.
  • Allowing newline-separated regexes makes it easier to paste multi-line filter lists into the MCP parameters and keeps behavior consistent with list inputs.

Description

  • When includere or excludere are provided as strings the code now calls split("\n").filter(r => r.length > 0) to coerce them into arrays and drop empty lines.
  • Applied the newline-splitting/empty-line filtering in ECR List Images and ECR Get Repository Report before building the haystack and running regex matches.
  • Preserves existing behavior when no filters are provided or when filters are already arrays, and continues to test each regex via new RegExp(...) against the assembled tag/digest haystack.

Testing

  • No automated tests were executed for this change.
  • No automated failures reported during the change application step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant