Replaces global pi value with std::numbers::pi_v<T>#68
Open
cugone wants to merge 1 commit intoOneLoneCoder:mainfrom
Open
Replaces global pi value with std::numbers::pi_v<T>#68cugone wants to merge 1 commit intoOneLoneCoder:mainfrom
cugone wants to merge 1 commit intoOneLoneCoder:mainfrom
Conversation
Owner
|
Hmmm, firstly it ruins my awesome joke :( . Secondly, I'm unconvinced it's an improvement - it's wordier and less clear. Just because the std has something, doesn't always mean it should. However I'm fair and quite malleable, convince me and others it's better and i'll merge it.
|
Author
|
https://godbolt.org/z/7eT476ocM I had to convince myself as well. They produce the same assembly output. The clarity argument can be mitigated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
This replaces the global double-only
pivariable withstd::numbers::pi_v<T>from the<numbers>header. As a bonus it plays nice with templates and can now be represented as both adoubleandfloatdepending on the template argument type instead of implicitly being cast to a float during multiplication operations.