Open
Conversation
added constructor, operator[], side, area, perimeter, side_count, is_convex and center functions
Owner
|
Thanks! Before fully jumping on the first polygon implementation PR, I've added a discussion page so we can flesh out the details of this fundamental type, and understand the implications of choosing the structure of such a fundamental, well, structure. Please see #59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added constructor that creates an empty polygon with n points, and common methods from other primitives (area, perimeter), as well as special methods that apply for polygons (is_convex).