refactor(vanish-service): Refactor the vanish service to uuid based #126
+114
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
TheMeinerLP
requested changes
Jan 25, 2026
Comment on lines
+57
to
+59
| boolean canSee(UUID viewerId, UUID targetId); | ||
|
|
||
| boolean isVanishPermitted(P player); | ||
| boolean isVanishPermitted(UUID playerId); |
| public class BukkitPlayerVanishService implements PlayerVanishService<Player> { | ||
| import java.util.UUID; | ||
|
|
||
| public class BukkitPlayerVanishService implements PlayerVanishService { |
Contributor
There was a problem hiding this comment.
can be final if this no api
| if (player == null) return; | ||
|
|
||
| plugin.getServer().getScheduler().getMainThreadExecutor(plugin) | ||
| .execute(() -> plugin.getServer().getOnlinePlayers().forEach(onlinePlayer -> { |
Contributor
There was a problem hiding this comment.
If you use stream you can cleanup the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request replaces the generic in the vanish service with uuid based methods.
Submitter Checklist
@since TODO.