Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

Remove previously added app_beacon_node_peer_id and move beacon node ID value to already existing metric beaconNodeVersionGauge.

image

category: feature
ticket: #4197

@DiogoSantoss DiogoSantoss self-assigned this Jan 29, 2026
@sonarqubecloud
Copy link

@KaloyanTanev KaloyanTanev added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Jan 29, 2026
@obol-bulldozer obol-bulldozer bot merged commit 33fe701 into main Jan 29, 2026
11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/fix-metric-beacon-node-id branch January 29, 2026 12:46
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.65%. Comparing base (f9042d5) to head (eca261a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
app/monitoringapi.go 0.00% 22 Missing ⚠️
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4264      +/-   ##
==========================================
- Coverage   56.91%   56.65%   -0.27%     
==========================================
  Files         237      237              
  Lines       31004    31329     +325     
==========================================
+ Hits        17646    17748     +102     
- Misses      11108    11308     +200     
- Partials     2250     2273      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants