Skip to content

Conversation

@KaloyanTanev
Copy link
Collaborator

  1. Previously we have tried to parse each proposer duty's key, but the proposer duty is the only duty request that don't filter on validator indices and rather returns all. In the previous implementation we had continue, what I've added now as well.
  2. Add a bit more debug logging on reorg
  3. Fix the cache metrics labels

category: bug
ticket: #4227

@KaloyanTanev KaloyanTanev self-assigned this Jan 29, 2026
@KaloyanTanev KaloyanTanev force-pushed the kalo/fix-duties-cache branch from 51a7d45 to 63dc189 Compare January 29, 2026 12:44
@KaloyanTanev KaloyanTanev force-pushed the kalo/fix-duties-cache branch from 63dc189 to 3db315b Compare January 29, 2026 12:47
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.73%. Comparing base (33fe701) to head (3db315b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/eth2wrap/cache.go 20.00% 8 Missing ⚠️
core/validatorapi/validatorapi.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4263      +/-   ##
==========================================
+ Coverage   56.61%   56.73%   +0.11%     
==========================================
  Files         237      237              
  Lines       31329    31332       +3     
==========================================
+ Hits        17736    17775      +39     
+ Misses      11320    11285      -35     
+ Partials     2273     2272       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OisinKyne OisinKyne added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 29, 2026
@obol-bulldozer obol-bulldozer bot merged commit 179a61a into main Jan 29, 2026
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/fix-duties-cache branch January 29, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants