Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

@DiogoSantoss DiogoSantoss commented Jan 28, 2026

Add new metric app_beacon_node_peer_id to track beacon node's peer IDs.

image

category: feature
ticket: #4197

@DiogoSantoss DiogoSantoss self-assigned this Jan 28, 2026
@DiogoSantoss DiogoSantoss added the do not merge Indicate to bulldozer bot that this PR should not be merged label Jan 28, 2026
@DiogoSantoss DiogoSantoss force-pushed the diogo/beacon-node-peer-id-metric branch from 3130cbf to 5cbb20e Compare January 28, 2026 13:09
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.60%. Comparing base (f9042d5) to head (6435f07).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/eth2wrap/multi.go 0.00% 11 Missing ⚠️
app/monitoringapi.go 0.00% 10 Missing ⚠️
app/eth2wrap/lazy.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4256      +/-   ##
==========================================
- Coverage   56.91%   56.60%   -0.31%     
==========================================
  Files         237      237              
  Lines       31004    31332     +328     
==========================================
+ Hits        17646    17737      +91     
- Misses      11108    11322     +214     
- Partials     2250     2273      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DiogoSantoss DiogoSantoss removed the do not merge Indicate to bulldozer bot that this PR should not be merged label Jan 28, 2026
@sonarqubecloud
Copy link

@DiogoSantoss DiogoSantoss added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 28, 2026
@KaloyanTanev KaloyanTanev merged commit 1707ded into main Jan 28, 2026
10 of 12 checks passed
@KaloyanTanev KaloyanTanev deleted the diogo/beacon-node-peer-id-metric branch January 28, 2026 15:58
KaloyanTanev pushed a commit that referenced this pull request Jan 29, 2026
* add beacon node peer_id metric

* use node identity from go-eth2-client

* clean rebase

* fix lint

* fix lint again

* move to gen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants