fix: eliminate hardcoded command names(move to distroless) #2075
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joji Mekkattuparamban <jojim@nvidia.com>
jojimt
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
Contributor
Author
cdesiniotis
approved these changes
Jan 27, 2026
Contributor
|
/ok to test fbcc05a |
jojimt
changed the title
jojimt
changed the title
Contributor
|
LGTM. Thanks Joji. |
elezar
reviewed
Jan 29, 2026
| preStop: | ||
| exec: | ||
| command: ["/bin/sh", "-c", "rm -f /run/nvidia/validations/.cc-manager-ctr-ready"] | ||
| command: ["/bin/rm", "-f", "/run/nvidia/validations/.cc-manager-ctr-ready"] |
Member
There was a problem hiding this comment.
Was this change intended to be part of this PR? At the very least I would expect this to be a separate commit since it is not related to removing the hard-coded command names.
Contributor
Author
There was a problem hiding this comment.
Yes, it is intended to be a part of this PR. The goal is to move to distroless which does not include the shell. This is also why we need the hardcoded names to be removed. I have updated the description and heading to mention this.
jojimt
changed the title
cdesiniotis
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the operands viz. cc-manager and sandbox device plugin have their commands hardcoded. This causes problems, e.g. when we move to python or make a command name change for any reason. Instead, we want to let the Dockerfile specify the entrypoint. This is needed for moving to distroless. Also, updated the preStop hook not to use shell, consistent with distroless.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual testing on a cluster. Verified preStop lifecycle hook as well.