Merged
Conversation
aromanielloNTIA
suggested changes
Dec 18, 2024
Contributor
aromanielloNTIA
left a comment
aromanielloNTIA
left a comment
There was a problem hiding this comment.
I am opening another PR to merge into this branch with a few revisions, primarily editorial. I will submit that for you to review, then we can merge this. Otherwise, looks great!
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "upload_type": "software", | |||
| "publication_date": "TODO-TEMPLATE", | |||
Contributor
There was a problem hiding this comment.
I am populating this file in a separate PR
CITATION.cff
Outdated
| message: Please cite this software using these metadata. | ||
| type: software | ||
| authors: | ||
| - family-names: Kozma |
Contributor
There was a problem hiding this comment.
Revising author information in separate PR alongside zenodo revisions
README.md
Outdated
| [doi-badge]: https://zenodo.org/badge/LFMF-python.svg | ||
| [doi-link]: https://zenodo.org/badge/latestdoi/LFMF-python | ||
|
|
||
| This code repository contains the U.S. Reference Software Implementation of |
Contributor
There was a problem hiding this comment.
Making some revisions in a separate PR
aromanielloNTIA
approved these changes
Dec 18, 2024
Contributor
aromanielloNTIA
left a comment
aromanielloNTIA
left a comment
There was a problem hiding this comment.
Looks good! Some things still remain before this is done: adding the test data submodule and incorporating recent template revisions. All of this will be handled within #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.