Disable single file compression on publish#558
Open
PJB3005 wants to merge 1 commit intoMutagen-Modding:devfrom
Open
Disable single file compression on publish#558PJB3005 wants to merge 1 commit intoMutagen-Modding:devfrom
PJB3005 wants to merge 1 commit intoMutagen-Modding:devfrom
Conversation
Single file compression makes Synthesis have easily 350+ MB of extra permanent memory usage because the data cannot be memory mapped anymore: dotnet/docs#50800 I would expect this shouldn't significantly hurt archive size, as the zip will also just apply compression. This does significantly increase the size on disk... but Skyrim modlists are absolutely huge already, so that seems acceptable to me? If the size on disk is a concern, disabling R2R seems like a much better idea. The current status seems absolutely terrible for startup time anyways.
Member
|
Thanks! It's been a while since I looked at the packaging side of the synthesis exe. I think my main concern was trying to get a single exe file, rather than a folder of clutter. Obviously that only does so much, as somehow lots of files still bleed into the zip, somehow. But, it is "better" than not doing single file. Is there a specific setting you're eying that I should try turning off? I dont mind tweaking the setup a bit if we have some ideas to improve |
Member
|
Oh, am dumb. Just noticed this was a PR, not an issue, haha. I'll try your adjustment and get back to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single file compression makes Synthesis have easily 350+ MB of extra permanent memory usage because the data cannot be memory mapped anymore: dotnet/docs#50800
I would expect this shouldn't significantly hurt archive size, as the zip will also just apply compression. This does significantly increase the size on disk... but Skyrim modlists are absolutely huge already, so that seems acceptable to me? If the size on disk is a concern, disabling R2R seems like a much better idea. The current status seems absolutely terrible for startup time anyways.