Add data product to record filtering fraction #1691
Conversation
|
Hi @brownd1978,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 33c5055: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 33c5055.
N.B. These results were obtained from a build of this Pull Request at 33c5055 after being merged into the base branch at 440d6ec. For more information, please check the job page here. |
sophiemiddleton
left a comment
sophiemiddleton
left a comment
There was a problem hiding this comment.
Thanks Dave, this definitely looks useful!
michaelmackenzie
left a comment
michaelmackenzie
left a comment
There was a problem hiding this comment.
I think this looks good and is very useful, thank you for making this update!
Can you please add this data product output to the Trigger/src/PrescaleEvent_module.cc prescale module? This may require a separate object for On-Spill and Off-Spill in this case.
|
I can also make the update to the Trigger prescaler module after this PR if that's easier! |
Can the OnSpill/OffSpill split be handled by having 2 instances of this module in different paths with the appropriate filter before them? |
I'd prefer for now to keep the trigger configuration as it is, without needing to duplicate all paths (or more multiplying if there are any other event modes) in order to have different pre-scales On-Spill and Off-Spill. The Trigger prescaler is designed to be able to handle different pre-scales for different event modes, without duplication. |
|
I think I addressed all the issues. I tested with on OnSpill digitization job (with Production PR 498) and see the new products look as expected. |
|
Example filedumper output: PRINCIPAL TYPE: SubRun |
4 participants
This is intended to record prescale factors, but is more generalized in case there are other uses.