Updates to the STM simulation framework

[PawelPlesniak]

This adds a set of updates to the STM simulation infrastructure. Details will be provided once complete.
Note to self - run tests on all written modules before uploading - there is a substantial rewrite included here.

[FNALbuild]

Hi @PawelPlesniak,
You have proposed changes to files in these packages:

• RecoDataProducts
• STMMC
• EventGenerator
• Analyses

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for cdad575: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at cdad575.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged cdad575 at a04e36a
build (prof)	✅	Log file. Build time: 04 min 33 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	❌	Log file. Return Code 1.
FIXME, TODO	🔶	TODO (7) FIXME (0) in 8 files
clang-tidy	🔶	14 errors 110 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at cdad575 after being merged into the base branch at a04e36a.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[YongyiBWu]

Hi Pawel, thank you for making these new updates. I also want to bring it to your attention that with the updated run-1a geometry, the NeuralsCat can actually give significant amount of neutrons in the STM downstream area due to the reduced shielding scheme. I am not sure if this affects you. I will make an update on this this coming Friday in the STM meeting.

[rlcee]

I can't comment on the physics goal, so I just looked at code style.
I don't see any problems except the missing cmake files should be fixed. I can't see the cmake log file any more (too old, purged?) so the CI should be run again to verify this was fixed or not.
Here are two items for consideration.

• Copied from Production/JobConfig/mixing/TwoBB.fcl
  obviously would be better to reference than copy
• nADCs = 542;
  this seems like something that should be in a header file of fixed numbers

[oksuzian]

@PawelPlesniak , do you want to implement Ray's suggestions before merging?

[FNALbuild]

📝 The HEAD of main has changed to 440d6ec. Tests are now out of date.

[PawelPlesniak]

Hi all, thank you so much reviewing, this is still a work in progress and would rather it be left as is until it is complete. Yongi and I will discuss time lines on Slack

[PawelPlesniak]

I will also implement codebase changes, including the cake lists changes that Ray suggested. The nADCs is a variable that should disappear in a future PR, but I will document any code that will need changes in the relevant modules to explain what it means and what needs to happen with it

[PawelPlesniak]

Also for reference, I have rebased this branch with develop prior to making the draft PR, and will be co-ordinating review with both the physics experts (Yongyi and Andrew Edmonds) and the core software managers (Ray and Yuri) prior to merging.