Adds a module which allows for borgs to do magic!#637
Open
Constellado wants to merge 14 commits intoMrMelbert:masterfrom
Open
Adds a module which allows for borgs to do magic!#637Constellado wants to merge 14 commits intoMrMelbert:masterfrom
Constellado wants to merge 14 commits intoMrMelbert:masterfrom
Conversation
- Gets rid of the item addition copypaste code (Why nobody did this for 7 years is beyond me) - Adds variable and proper checks for if a module is already installed (Borgs will no longer eat up unlimited masses of lavaproof track upgrades, among others) (Technically this never allows duplicates, at least currently, as I don't recall any modules being capable to used multiple times intentionally without also deleting themselves with single_use) - Unsingleletters most if not all of `robot_upgrades.dm` Makes the borg module code much cleaner, makes it significantly easier for new ones to be added. Fixes unintended behaviour with some modules being able to stack, which until now was always solved by copypasting code. :cl: fix: Fixed some borg modules just being constantly eaten up by borgs even when they shouldn't allow duplicates refactor: Borg module code now has better handling for adding/removing items, and to prevent duplicate module usage (Unless one wishes to override the behaviour. /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com>
- Complete rewrite of borg omnitool code; - - Borgs that use omnitools now have a "Omni Toolbox" that holds whatever tools the Omnitool would cover. The toolbox keeps track of Omnitool "Arms" in a list, as well as when to upgrade (or downgrade) tool speed. The toolbox is not seen by the player directly. - - Omnitool "Arms" will display available tools based on the Omni Toolbox's contents. Selecting one does not move the tool out of the toolbox, but instead simply overrides any following clicks with a melee attack chain of the selected item. This is reminiscent of how borg apparatus tools work. When selecting a tool, the Omnitool "arm" will also set its own icon state to match the tool selected. - - Because all Omnitool "arms" are using the same tools from the same toolbox, actions done with one can be seen from another. For example, using the first Omnitool to scan the Silo with the engineer borg's multitool will update the tool's buffer, and it can be used later, even if the multitool is selected by the second Omnitool. - Because we're now using real tools, rather than a single tool item faking tool usage via tool flags, almost all interactions with tools should properly carry over. - Added Cyborg versions of the medical toolset, for use with the Medical Cyborg omnitool, so that we can finally use the really nice borg-version medical tool sprites. Easier to read code. Fixes #83667 Fixes #83537 Fixes #83077 Fixes #82918 partially; Heating beakers works, but the tile quick-swap function will not function; the action is initiated by a click from the tile stack rather than the crowbar. :cl: fix: Refactored borg omnitool code, fixing most of the unique interaction issues. /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Constellado
changed the title
Constellado
changed the title
This reverts commit 725f66f.
- Complete rewrite of borg omnitool code; - - Borgs that use omnitools now have a "Omni Toolbox" that holds whatever tools the Omnitool would cover. The toolbox keeps track of Omnitool "Arms" in a list, as well as when to upgrade (or downgrade) tool speed. The toolbox is not seen by the player directly. - - Omnitool "Arms" will display available tools based on the Omni Toolbox's contents. Selecting one does not move the tool out of the toolbox, but instead simply overrides any following clicks with a melee attack chain of the selected item. This is reminiscent of how borg apparatus tools work. When selecting a tool, the Omnitool "arm" will also set its own icon state to match the tool selected. - - Because all Omnitool "arms" are using the same tools from the same toolbox, actions done with one can be seen from another. For example, using the first Omnitool to scan the Silo with the engineer borg's multitool will update the tool's buffer, and it can be used later, even if the multitool is selected by the second Omnitool. - Because we're now using real tools, rather than a single tool item faking tool usage via tool flags, almost all interactions with tools should properly carry over. - Added Cyborg versions of the medical toolset, for use with the Medical Cyborg omnitool, so that we can finally use the really nice borg-version medical tool sprites. Easier to read code. Fixes #83667 Fixes #83537 Fixes #83077 Fixes #82918 partially; Heating beakers works, but the tile quick-swap function will not function; the action is initiated by a click from the tile stack rather than the crowbar. :cl: fix: Refactored borg omnitool code, fixing most of the unique interaction issues. /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-Authored-By: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
This reverts commit 601f607.
…116)" This reverts commit b9f3c43.
Co-Authored-By: Ossa88 (SYNAPSE) <8151625+ossa88@users.noreply.github.com>
github-actions
bot
added
Sprites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
A borg module which adds the ability for a borg to do spells! The spells are pulled from the preferences that you set when you made your character.
This is what it looks like!
todo: