refactor: weight refactor, including norm, mm, quantization and embedding #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sufubao <sufubao@sensetime.com>
hiworldwzj
reviewed
Jan 27, 2026
| self.quanted_weight_names = quanted_weight_names | ||
| else: | ||
| self.quanted_weight_names = None | ||
| self.weight_names = quanted_weight_names |
Collaborator
There was a problem hiding this comment.
这个地方直接将 weight_names 赋值为新的quanted_weight_names会不会导致在 权重不是量化好的权重情况中，无法找到对应的权重，导致加载失败。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.