Draft
Conversation
…t-predictor # Conflicts: # src/main/java/meteordevelopment/meteorclient/mixin/ScreenMixin.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds a chest predictor module that predicts chest loot based on the seed. It works by detecting structure pieces using their NBT file, and from there inferring the loot table of the chest. The loot seed can be calculated using just the world seed and the chest's coordinates. To emulate the loot generation, I used Cubiomes. It would be better if one were able to use Minecraft's own loot generation code, but it's highly coupled with server side logic, making it infeasible to use (for example every loot function has
ServerLevelas parameter).The PR is a draft for at least three reasons:
I mostly wanted to get the PR out there for perhaps an initial review.
Related issues
None.
How Has This Been Tested?
https://streamable.com/8ragqe
Checklist: