Skip to content

Fix settings not visually updating #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wide-Cat merged 3 commits into from
Jan 21, 2026
Merged

Fix settings not visually updating #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62c33d7
Added invalidation to Settings
X-C-0 Jan 20, 2026
34cb22f
Made HudTab and ProfilesTab call super.tick() just like ConfigTab
X-C-0 Jan 20, 2026
7603c82
Added the ability to invalidate the Settings for addons
X-C-0 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/meteordevelopment/meteorclient/gui/tabs/builtin/HudTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import meteordevelopment.meteorclient.gui.tabs.Tab;
import meteordevelopment.meteorclient.gui.tabs.TabScreen;
import meteordevelopment.meteorclient.gui.tabs.WindowTabScreen;
import meteordevelopment.meteorclient.gui.widgets.containers.WContainer;
import meteordevelopment.meteorclient.gui.widgets.containers.WHorizontalList;
import meteordevelopment.meteorclient.gui.widgets.pressable.WButton;
import meteordevelopment.meteorclient.gui.widgets.pressable.WCheckbox;
Expand Down Expand Up @@ -37,6 +38,7 @@ public boolean isScreen(Screen screen) {
}

public static class HudScreen extends WindowTabScreen {
private WContainer settingsContainer;
private final Hud hud;

public HudScreen(GuiTheme theme, Tab tab) {
Expand All @@ -48,7 +50,8 @@ public HudScreen(GuiTheme theme, Tab tab) {

@Override
public void initWidgets() {
add(theme.settings(hud.settings)).expandX();
settingsContainer = add(theme.verticalList()).expandX().widget();
settingsContainer.add(theme.settings(hud.settings)).expandX().widget();

add(theme.horizontalSeparator()).expandX();

Expand Down Expand Up @@ -77,6 +80,13 @@ protected void onRenderBefore(DrawContext drawContext, float delta) {
HudEditorScreen.renderElements(drawContext);
}

@Override
public void tick() {
super.tick();

hud.settings.tick(settingsContainer, theme);
}

@Override
public boolean toClipboard() {
return NbtUtils.toClipboard(hud);
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/meteordevelopment/meteorclient/gui/tabs/builtin/ProfilesTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ public void initWidgets() {

@Override
public void tick() {
super.tick();

profile.settings.tick(settingsContainer, theme);
}

Expand Down
17 changes: 15 additions & 2 deletions src/main/java/meteordevelopment/meteorclient/settings/Settings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

public class Settings implements ISerializable<Settings>, Iterable<SettingGroup> {
private SettingGroup defaultGroup;
private boolean invalidate;

public final List<SettingGroup> groups = new ArrayList<>(1);

public void onActivated() {
Expand Down Expand Up @@ -61,6 +63,12 @@ public void reset() {
setting.reset();
}
}

invalidate();
}

public void invalidate() {
invalidate = true;
}

public SettingGroup getGroup(String name) {
Expand Down Expand Up @@ -125,13 +133,18 @@ public void tick(WContainer settings, GuiTheme theme) {
boolean visible = setting.isVisible();

if (visible != setting.lastWasVisible) {
settings.clear();
settings.add(theme.settings(this)).expandX();
invalidate();
}

setting.lastWasVisible = visible;
}
}

if (invalidate) {
settings.clear();
settings.add(theme.settings(this)).expandX();
invalidate = false;
}
}

@Override
Expand Down