Merged
Conversation
ffmcgee725
reviewed
Apr 17, 2025
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING**: `initializeProvider` announces the extensionId, when available, via a `caip-348` target on in the new `targets` property of the CAIP-294 wallet announcement event instead of the previous `extensionId` property ([#413](https://github.com/MetaMask/providers/pull/413)) |
Member
There was a problem hiding this comment.
Should we have a link to CAIP-294 here ? Even though it's to be merged still
Contributor
There was a problem hiding this comment.
ehh. i vote no, not until it is finalized and merged. Alex asked the same though. I don't feel it's worth it until a more permanent link for it exists
Member
There was a problem hiding this comment.
It's just that it would "look good" to have it here , easily accessible, and most likely we won't remember in the future to come back here and link it. And it's safe to say it WILL get merged...eventually... 💀
Don't see this as blocker though
ffmcgee725
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 22.0.0.