Conversation
jiexi
commented
Apr 15, 2025
| const extensionId = providerState?.extensionId; | ||
| if (extensionId) { | ||
| targets.push({ | ||
| type: 'caip-348', |
Contributor
Author
There was a problem hiding this comment.
i've gone back and forth on whether this belongs in a constant, and I don't think it's necessary because we don't do this for other standards numbers. The value itself is already effectively a symbol and moving it to a constant doesn't really buy us additional value
Contributor
There was a problem hiding this comment.
Should we add a link to the CAIP PR?
7 tasks
adonesky1
reviewed
Apr 16, 2025
| * @returns Whether the {@link CAIP294Target} is valid. | ||
| */ | ||
| function isValidWalletTarget(data: unknown): data is CAIP294Target { | ||
| return isObject(data) && typeof data.type === 'string' && Boolean(data.type); |
Contributor
There was a problem hiding this comment.
is Boolean(data.type) just to check that its not an empty string?
Contributor
Author
There was a problem hiding this comment.
yeah.... it's what Erik had before i think, so i just kept the pattern
adonesky1
reviewed
Apr 16, 2025
| * @property type - The type of the target. SHOULD reference a CAIP number in the `caip-x` format. | ||
| * @property value - The value specifying how to connect to the target as specified by the specification in the `type` property. | ||
| */ | ||
| export type CAIP294Target = { type: string; value?: unknown }; |
Contributor
There was a problem hiding this comment.
Also should we add some links to CAIP-294 here?
Contributor
Author
There was a problem hiding this comment.
to the PR? it hasn't been merged yet so the link isn't going to be great
adonesky1
previously approved these changes
Apr 16, 2025
ffmcgee725
reviewed
Apr 17, 2025
Co-authored-by: ffmcgee <51971598+ffmcgee725@users.noreply.github.com>
ffmcgee725
approved these changes
Apr 17, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 18, 2025
…Multichain API externally_connectable protocol (#32070) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/32070?quickstart=1) ## **Related issues** See: MetaMask/test-dapp-multichain#53 See: MetaMask/providers#413 See: MetaMask/multichain-api-client#40 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/32070?quickstart=1){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
targetstowallet_announceevent datacaip-348and extensionId for chromium metamask extensionSee: pedrouid/CAIPs#9
See: ChainAgnostic/CAIPs#348
See: MetaMask/metamask-extension#32070