Skip to content

#VFB-227 - Apply queries grouping in the term info to the new VFB#208

Open
jrmartin wants to merge 6 commits intodevelopmentfrom
feature/VFB-227
Open

#VFB-227 - Apply queries grouping in the term info to the new VFB#208
jrmartin wants to merge 6 commits intodevelopmentfrom
feature/VFB-227

Conversation

@jrmartin
Copy link
Collaborator

Update term info queries section to display queries grouped as in v2 version of vfb. Keeps displaying inner Table of preview of queries when expanding a query. For those queries who are not part of a group, they get place under Other Queries. This last part is a bit of a change from v2.virtualflybrain, as those leaf queries where groupless there, whereas in dev we have a new group call Other Queries where these leafless queries can be placed as in screenshot and this branch. @ddelpiano

v2 vs dev2 V2 vs dev

This pull request refactors and enhances the way queries are grouped and displayed in the TermInfo component. The main changes include introducing configurable query groupings, improving state management for queries data, and updating the UI to reflect these new groupings for a more organized and scalable presentation.

Query grouping and UI improvements:

  • Introduced a queryGroups configuration to categorize queries by label prefixes, and created logic to group queries accordingly, making it easier to manage and extend groupings in the future.
  • Updated the rendering logic in the SimpleTreeView to iterate over these groups, displaying each group and its queries in a structured way. The "Other queries" section now cleanly displays any queries not matching the predefined groups. [1] [2] [3] [4] [5]

State management enhancements:

  • Added a queriesData state to manage queries independently of the main termInfoData, ensuring that updates to the data prop are reflected in both pieces of state. [1] [2]

UI consistency and accessibility:

  • Updated tree item keys and IDs to include group and index information, improving React key uniqueness and accessibility. [1] [2] [3]

Minor UI tweaks:

  • Changed default icons for expand/collapse in SimpleTreeView for better clarity.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2372f2bb53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ddelpiano ddelpiano requested a review from Copilot February 2, 2026 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Term Info queries section to group queries by category, mirroring the organization used in VFB v2. Queries are now organized into predefined groups (e.g., "Types of neurons with...", "Individual neurons with"), while ungrouped queries appear under a new "Other Queries" section.

Changes:

  • Introduced configurable query grouping logic based on label prefixes
  • Added separate state management for queries data to ensure proper updates
  • Updated UI rendering to display grouped queries with correct counts and IDs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 15 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jrmartin jrmartin requested a review from ddelpiano February 3, 2026 00:17
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2026-02-03 11-44-04

@jrmartin jrmartin requested a review from ddelpiano February 3, 2026 16:25
@jrmartin
Copy link
Collaborator Author

jrmartin commented Feb 3, 2026

@ddelpiano Fixed that bug, a missing conditional check missed within the elements

@jrmartin
Copy link
Collaborator Author

jrmartin commented Feb 3, 2026

image @ddelpiano Deployed to dev and confirmed it loads showing queries preview tables on TermInfo, like before, while adding the new grouping to queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants