#VFB-227 - Apply queries grouping in the term info to the new VFB#208
#VFB-227 - Apply queries grouping in the term info to the new VFB#208jrmartin wants to merge 6 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2372f2bb53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR updates the Term Info queries section to group queries by category, mirroring the organization used in VFB v2. Queries are now organized into predefined groups (e.g., "Types of neurons with...", "Individual neurons with"), while ungrouped queries appear under a new "Other Queries" section.
Changes:
- Introduced configurable query grouping logic based on label prefixes
- Added separate state management for queries data to ensure proper updates
- Updated UI rendering to display grouped queries with correct counts and IDs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx
Outdated
Show resolved
Hide resolved
… dduplicate id naming convention of elements
|
@ddelpiano Fixed that bug, a missing conditional check missed within the elements |
@ddelpiano Deployed to dev and confirmed it loads showing queries preview tables on TermInfo, like before, while adding the new grouping to queries.
|


Update term info queries section to display queries grouped as in v2 version of vfb. Keeps displaying inner Table of preview of queries when expanding a query. For those queries who are not part of a group, they get place under Other Queries. This last part is a bit of a change from v2.virtualflybrain, as those leaf queries where groupless there, whereas in dev we have a new group call Other Queries where these leafless queries can be placed as in screenshot and this branch. @ddelpiano
This pull request refactors and enhances the way queries are grouped and displayed in the
TermInfocomponent. The main changes include introducing configurable query groupings, improving state management for queries data, and updating the UI to reflect these new groupings for a more organized and scalable presentation.Query grouping and UI improvements:
queryGroupsconfiguration to categorize queries by label prefixes, and created logic to group queries accordingly, making it easier to manage and extend groupings in the future.SimpleTreeViewto iterate over these groups, displaying each group and its queries in a structured way. The "Other queries" section now cleanly displays any queries not matching the predefined groups. [1] [2] [3] [4] [5]State management enhancements:
queriesDatastate to manage queries independently of the maintermInfoData, ensuring that updates to the data prop are reflected in both pieces of state. [1] [2]UI consistency and accessibility:
Minor UI tweaks:
SimpleTreeViewfor better clarity.