CH-234 feat: Allow secrets with quotes#832
Open
afonsobspinto wants to merge 2 commits intodevelopfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements support for secrets containing single quotes in Codefresh deployments by wrapping placeholder values in double quotes.
Changes:
- Modified the secret placeholder format to wrap
${{VAR}}references in double quotes - Added test coverage for secrets containing single quotes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ch_cli_tools/codefresh.py | Updated secret placeholder formatting to wrap references in double quotes |
| tests/test_codefresh.py | Added test case to verify secrets with quotes are handled correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://metacell.atlassian.net/browse/CH-234
Implemented solution
Wraps the ${{VAR}} placeholder in double quotes, so values containing single quotes are preserved when injected.
How to test this PR
Set a codefresh secret with quotes in it. (test_codefresh_secret_with_quotes test case was added)
Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):