Skip to content

CH-234 feat: Allow secrets with quotes#832

Open
afonsobspinto wants to merge 2 commits intodevelopfrom
feature/CH-234
Open

CH-234 feat: Allow secrets with quotes#832
afonsobspinto wants to merge 2 commits intodevelopfrom
feature/CH-234

Conversation

@afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Feb 2, 2026

Closes https://metacell.atlassian.net/browse/CH-234

Implemented solution

Wraps the ${{VAR}} placeholder in double quotes, so values containing single quotes are preserved when injected.

How to test this PR

Set a codefresh secret with quotes in it. (test_codefresh_secret_with_quotes test case was added)

Sanity checks:

  • [z] The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change and the migration procedure is well described above

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for secrets containing single quotes in Codefresh deployments by wrapping placeholder values in double quotes.

Changes:

  • Modified the secret placeholder format to wrap ${{VAR}} references in double quotes
  • Added test coverage for secrets containing single quotes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ch_cli_tools/codefresh.py Updated secret placeholder formatting to wrap references in double quotes
tests/test_codefresh.py Added test case to verify secrets with quotes are handled correctly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant