feat!: cythonise all sources#176
Draft
P403n1x87 wants to merge 1 commit intoMatthieuDartiailh:mainfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 95.37% 4.29% -91.09%
==========================================
Files 7 7
Lines 2142 2142
Branches 483 483
==========================================
- Hits 2043 92 -1951
- Misses 56 2040 +1984
+ Partials 43 10 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for opening this. I am not sure when I will be able to follow up. Among the failures I noticed a comparison of instruction name which could be optimized as an integer comparison. |
86db41f to
217b80c
Compare
Owner
|
I tried rebasing but now all tests are failing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat all sources as Cython sources for improved performance