Fix up linting errors found by the new js-lint

[CDeltakai]

Description

This is a small PR that simply fixes up some of the linting errors discovered by the new js-lint.

Issues Fixed

Tasks

• 1. Fix up any linting errors found by the new js-lint package.

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[CDeltakai]

RWLockReader.ts and RWLockWriter.ts contained a few conditional branches that were unreachable. These branches were trying to equate typeof to null, which would always end up false because typeof always returned a string.

However, seeing as this branch has never been executed, and no problems have arisen from it not executing for a long time, the simplest solution was just to remove the branches entirely to preserve identical functionality.

[CDeltakai]

In Lockbox.ts and Monitor.ts, the waitPs array is reversed with the reverse() method in the waitForUnlock method. This returns a PromiseCancellable<void>[], however that promise is never handled in any way which causes a linting error for no-floating-promises.

However, in this case it seems that we are only interested in the side-effect of reverse() and there is nothing to do with the returned promise anyway, therefore the most logical solution would be to explicitly ignore the returned promise with void.