WIP: Attempt to bring in import/no-cycle rule to detect import cycles

[CMCDragonkai]

Description

Import cycles are a problem in PK. This seems to help detect it. I'm still evaluating it's safety and robustness.

Tasks

• 1. Check if we are missing a dependency Is this necessary for import/no-cycle? import-js/eslint-import-resolver-typescript#106
• 2. Try out different kinds of import cycles
• 3. Identify where we have legal import cycles and how to disable the rule like in our src/errors.ts in js-polykey

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend