Skip to content

ISSUE-7795: Impede long exam template names and provide better error messaging#7796

Open
Naragod wants to merge 8 commits intomasterfrom
ISSUE-7795_remove_scanned_exam_template_name_size_limit
Open

ISSUE-7795: Impede long exam template names and provide better error messaging#7796
Naragod wants to merge 8 commits intomasterfrom
ISSUE-7795_remove_scanned_exam_template_name_size_limit

Conversation

@Naragod
Copy link
Contributor

@Naragod Naragod commented Jan 21, 2026

Proposed Changes

Users who wish to upload scanned templates must give them 20 characters or shorter name, otherwise they will experience the following error: This job failed due to the following error: code length overflow. (276>272). (Try a larger size!)

Let's improve the error message showed to the user if they give a file too long of a name.

Screenshot 2026-01-22 at 10 24 45 PM
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@Naragod Naragod added this to the v2.9.1 milestone Jan 21, 2026
@Naragod Naragod requested a review from donny-wong January 21, 2026 20:37
@Naragod Naragod linked an issue Jan 21, 2026 that may be closed by this pull request
@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 7c9502a to 439b983 Compare January 21, 2026 20:39
@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2026

Pull Request Test Coverage Report for Build 21699083821

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 91.688%

Totals Coverage Status
Change from base Build 21688899174: 0.005%
Covered Lines: 44541
Relevant Lines: 47770

💛 - Coveralls

@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 6933d0c to 503e9c5 Compare January 27, 2026 15:39
@donny-wong donny-wong modified the milestones: v2.9.1, v2.9.2 Jan 29, 2026
@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch 2 times, most recently from 57b2545 to 09bf3a0 Compare February 2, 2026 16:02
@Naragod Naragod requested a review from donny-wong February 2, 2026 16:02
@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 09bf3a0 to 085adc5 Compare February 3, 2026 15:28
@Naragod Naragod changed the title ISSUE-7795: Remove scanned exam template name size limit ISSUE-7795: Impede long exam template names and provide better error messaging Feb 3, 2026
@Naragod Naragod modified the milestones: v2.9.2, v2.9.3 Feb 3, 2026
@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 085adc5 to 6c88a0d Compare February 3, 2026 18:45
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Naragod, I left a few comments but the changes are good. However, I think you also suggested adding a front-end validation on the create_new_template modal to restrict the "name" field to 20 characters. I think that would be a great addition to this PR (and pretty simple to do).

@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 6c88a0d to 39dbbd8 Compare February 5, 2026 04:06
@Naragod Naragod requested a review from david-yz-liu February 5, 2026 04:18
@Naragod Naragod force-pushed the ISSUE-7795_remove_scanned_exam_template_name_size_limit branch from 39dbbd8 to c4b5e10 Compare February 5, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scanned Exam Templates Error Out On Long Names

4 participants