ISSUE-7795: Impede long exam template names and provide better error messaging#7796
Open
ISSUE-7795: Impede long exam template names and provide better error messaging#7796
Conversation
7c9502a to
439b983
Compare
Collaborator
Pull Request Test Coverage Report for Build 21699083821Details
💛 - Coveralls |
6933d0c to
503e9c5
Compare
donny-wong
reviewed
Jan 28, 2026
57b2545 to
09bf3a0
Compare
donny-wong
approved these changes
Feb 2, 2026
09bf3a0 to
085adc5
Compare
085adc5 to
6c88a0d
Compare
david-yz-liu
reviewed
Feb 4, 2026
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
Thanks @Naragod, I left a few comments but the changes are good. However, I think you also suggested adding a front-end validation on the create_new_template modal to restrict the "name" field to 20 characters. I think that would be a great addition to this PR (and pretty simple to do).
6c88a0d to
39dbbd8
Compare
39dbbd8 to
c4b5e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Users who wish to upload scanned templates must give them 20 characters or shorter name, otherwise they will experience the following error:
This job failed due to the following error: code length overflow. (276>272). (Try a larger size!)Let's improve the error message showed to the user if they give a file too long of a name.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)