Fix: remove non-pip apturl dependency to enable cross-platform setup#97
Open
kunalsanga wants to merge 1 commit intoML4SCI:mainfrom
Open
Fix: remove non-pip apturl dependency to enable cross-platform setup#97kunalsanga wants to merge 1 commit intoML4SCI:mainfrom
kunalsanga wants to merge 1 commit intoML4SCI:mainfrom
Conversation
Author
|
Tested on Windows (Python 3.12) in a fresh virtual environment. |
huberthuang0930
approved these changes
Jan 21, 2026
huberthuang0930
left a comment
There was a problem hiding this comment.
Tested PR #97 on Windows (fresh venv).
- Python: 3.13.5
- Verified
apturl==0.5.2is removed fromGrid_based_strong_lensing_for_unsupervised_super_resolution_Anirudh_Shankar/requirements.txt - Confirmed the original failure reproduces:
pip install apturl==0.5.2-> “No matching distribution found” pip install -r requirements.txtnow proceeds past the previous apturl blocker (this PR fixes the issue’s root cause)
Note: the requirements file still includes several Ubuntu/Linux-specific packages (e.g., python-apt, systemd-python, Brlapi, etc.) that may still fail on Windows/macOS. That looks like a separate cleanup task from this PR’s scope — I’m happy to open a follow-up issue/PR to split platform-specific deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a setup blocker where
apturl(an Ubuntu-only system package)was included in
requirements.txt, causing installation failures onWindows and macOS.
Changes:
apturlfrom pip requirementsThis improves onboarding and allows new contributors to set up the project
on a clean, cross-platform environment.
Closes #96