Fix: make_log_grid argument mismatch in Grid-Based Strong Lensing notebooks#119
Open
Shrishagk wants to merge 1 commit intoML4SCI:mainfrom
Open
Fix: make_log_grid argument mismatch in Grid-Based Strong Lensing notebooks#119Shrishagk wants to merge 1 commit intoML4SCI:mainfrom
Shrishagk wants to merge 1 commit intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a breaking issue in the Grid-based strong lensing pipeline caused by an update to the function:
The function signature in the current repository requires an additional argument:
However, several notebooks and scripts still call the older 3-argument version:
This leads to the runtime error:
Testing
1.Verified log grid generation runs without errors
2.Forward lensing and grid mapping work as expected
3No changes to numerical outputs beyond expected log-grid configuration
This fix was discovered while working on PR #112.
This PR isolates the bug fix related to make_log_grid argument mismatch.