D3D updates #428
Open
D3D updates #428
+66
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @akeeste I added the updates for the updated variable names in the Delft3D 2025 version. I was thinking about updating the code to also accept xarry in addition to netCDF. |
Contributor
Author
|
Hey @akeeste pending all the checks pass, this is ready for review. |
Contributor
|
Thanks @browniea I'll look for some time to review next week |
akeeste
requested changes
Feb 3, 2026
| gci: float | ||
| Grid Convergence Index (GCI). | ||
| """ | ||
| # Calculate the approximate relative error |
Contributor
There was a problem hiding this comment.
Add basic type checks (all inputs are numerical, fine_grid and coarse_grid are the same shape, etc)
| if not isinstance(data, netCDF4.Dataset): | ||
| raise TypeError("data must be a NetCDF4 object") | ||
| if not isinstance(data, (netCDF4.Dataset, xr.Dataset)): | ||
| raise TypeError("data must be a NetCDF4 object or xarray Dataset") |
Contributor
There was a problem hiding this comment.
Add a test for xarray input
| ) | ||
| waterlevel = np.ma.getdata(data.variables["mesh2d_s1"][time_index, :], False) | ||
| coords = str(data.variables["waterdepth"].coordinates).split() | ||
| coords = str(data.variables["mesh2d_waterdepth"].coordinates).split() |
Contributor
There was a problem hiding this comment.
A couple questions on this change:
- When did this variable name become relevant
- Is the old
waterdepthvariable name still relevant?
| ): | ||
| """ | ||
| Calculate the Grid Convergence Index (GCI) between two grid sizes. https://www.grc.nasa.gov/WWW/wind/valid/tutorial/spatconv.html | ||
|
|
Contributor
There was a problem hiding this comment.
add the full citation to the above documentation in case the link ever breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
io/d3d.pycodecalculate_grid_convergence_indexfunction to calculate the grid convergence index between two grid's results basted on the equation GCI