Skip to content

Conversation

@yakushabb
Copy link
Contributor

@yakushabb yakushabb commented Jan 19, 2026

Description

The libnotify module is provided in various versions by different runtimes.

I've included below a list of runtimes and the provided libnotify versions.

Unless there is a particular requirement, you may not need to compile it.

Thanks.

Freedesktop 25.08 : "0.8.6"
Freedesktop 24.08 : "0.8.3"

Copy of: flathub/dev.lizardbyte.app.Sunshine#192

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher changed the title Drop libnotify module build(flatpak): drop libnotify module Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.47%. Comparing base (19a6301) to head (fe9e552).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4604      +/-   ##
==========================================
- Coverage   15.47%   15.47%   -0.01%     
==========================================
  Files          94       94              
  Lines       19025    19025              
  Branches     8769     8769              
==========================================
- Hits         2945     2944       -1     
- Misses      14267    14944     +677     
+ Partials     1813     1137     -676     
Flag Coverage Δ
Archlinux 11.54% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.81% <ø> (+0.01%) ⬆️
Homebrew-ubuntu-22.04 13.29% <ø> (ø)
Linux-AppImage 11.85% <ø> (ø)
Windows-AMD64 13.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 41 files with indirect coverage changes

@codecov
Copy link

codecov bot commented Jan 20, 2026

Bundle Report

Bundle size has no change ✅

The libnotify module is provided in various versions by different runtimes.

I've included below a list of runtimes and the provided libnotify versions.

Unless there is a particular requirement, you may not need to compile it.

Thanks.

```
Freedesktop 25.08 : "0.8.6"
Freedesktop 24.08 : "0.8.3"
```
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit ff770d6 into LizardByte:master Jan 21, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants