Fixing some errors in new version of web pack#48
Open
chaitanyagurrapu wants to merge 2 commits intoLemoncode:masterfrom
Open
Fixing some errors in new version of web pack#48chaitanyagurrapu wants to merge 2 commits intoLemoncode:masterfrom
chaitanyagurrapu wants to merge 2 commits intoLemoncode:masterfrom
Conversation
nasdan
reviewed
Oct 11, 2017
| @@ -167,15 +167,14 @@ Create a file named `webpack.config.js` in the root directory with the following | |||
|
|
|||
| ```javascript | |||
| var path = require('path'); | |||
Member
There was a problem hiding this comment.
Seems like we need to change all code by this one, isn't it?
Contributor
Author
There was a problem hiding this comment.
Not all code. Just a few changes around the "ExtractTextPlugin". I made another pull request with my existing webconfig.dev.js. Most of the things that show up as "diff's" in that PR seem to be space/indenting issues. Please have a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.