Add error prone support and perform code cleanups#127
Open
Conversation
kostis
force-pushed
the
error-prone-cleanups
branch
3 times, most recently
from
ce8262c to
1a7ccd6
Compare
It's an implementation detail whether compareTo returns {-1, 0, 1} or
some other value, so all comparisons should be against zero.
These libraries are more efficient in most cases. In a few places where this was not possible, some @SuppressWarning annotations were used instead.
kostis
force-pushed
the
error-prone-cleanups
branch
from
216b8b9 to
73b7fc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
error-proneand performs various clean ups to the code base. While at it, some optimizations were also performed.It's a relatively big set of changes, touching 70+ files, but its 30 commits are quite small and pretty self-explanatory if one wants to examine them in the chronological order that they were done, instead of reviewing the files which were changed. Also, they have the property that the tests pass after each commit, so it should be easy to change or omit some commit if we want to do it for some reason.