Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
This pull request introduces a user-facing toggle for haptic feedback within the Live Listen feature. This includes implementing persistent storage for the user's preference, integrating the setting across the Haptic, Audio, and ViewModel layers, and updating the
OrbLiveListenViewUI with a new button arrangement to host the toggle.✨ Features/Changes
📳 Haptics Toggle Feature
isHapticsEnabledproperty toHapticManager, usingUserDefaultsto store the user's preference and setting a default value on first run.HapticManagerlogic to strictly check theisHapticsEnabledstate before any haptic feedback is triggered, ensuring the user's preference is respected.🔗 Integration Across Layers
isHapticsEnabledproperty and thetoggleHaptics()method viaAudioPostProcessingManagerto act as a pass-through layer.isHapticsEnabled,toggleHaptics()) toOrbLiveListenViewModelto facilitate easy two-way binding with the UI.✨ UI Updates (
OrbLiveListenView)📁 Files Changed
HapticManager.swift- Added persistent storage and conditional haptics trigger logic.AudioPostProcessingManager.swift- Added pass-through logic for haptics state and toggle.OrbLiveListenViewModel.swift- Added pass-through properties and methods for UI binding.OrbLiveListenView.swift- Replaced floating button with new button row containing the haptics toggle and share button.🔧 Usage Examples (if applicable)