Allow a function als validation message#591
Open
hoetmaaiers wants to merge 3 commits intoKnockout-Contrib:masterfrom
Open
Allow a function als validation message#591hoetmaaiers wants to merge 3 commits intoKnockout-Contrib:masterfrom
hoetmaaiers wants to merge 3 commits intoKnockout-Contrib:masterfrom
Conversation
|
Seems that this PR is not appropriate anymore, while playing around and trying to reimplement this, found appropriate tests, so if you wish to use messages as functions you may do something like this: self.dateBirth = ko.observable().extend({
required: {
params: true,
message: function (params, observable) {
return self.resources.errorMessageDateBirthRequired.label();
}
}
}); |
|
Thanks @mac2000, I needed to add i18n support to validation messages and your solution works like a champ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By allowing a function in the
validationMessagebinding, it is possible to for example use another knockout observable as the validation message. The following example is used in our application for dynamically updating the validation message. I18n is provided by i18next.js for the whole application.Not sure if any tests are written for this custom binding?