Move buildfailuredetails to buildfailure table
#3400
+201
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `buildfailuredetails` table is used to deduplicate recurring build failures. In practice, both of these tables are several orders of magnitude smaller than the build2test and testoutput tables, and deduplicating errors doesn't save much space. The crc32-based deduplication process is also problematic due to the low entropy hash function and need for relatively complex logic when inserting new records. This commit simplifies the schema by merging the columns of the `buildfailuredetails` table into the `buildfailure` table, bringing it in line with the similar `builderror` table. Follow-up work will merge the `builderror` and `buildfailure` tables.
Collaborator
Author
|
Requesting a double review since this is a relatively large change. |
josephsnyder
approved these changes
Jan 28, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM. I don't see anything that worries me in the exploration of the testing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildfailuredetailstable is used to deduplicate recurring build failures. In practice, both of these tables are several orders of magnitude smaller than the build2test and testoutput tables, and deduplicating errors doesn't save much space. The crc32-based deduplication process is also problematic due to the low entropy hash function and need for relatively complex logic when inserting new records. This commit simplifies the schema by merging the columns of thebuildfailuredetailstable into thebuildfailuretable, bringing it in line with the similarbuilderrortable. Follow-up work will merge thebuilderrorandbuildfailuretables.