Skip to content

Conversation

@zoo-github-actions-auth
Copy link
Contributor

Updating the spec from that in the api repo

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (2a5a8de) to head (27cc11d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   69.44%   69.44%           
=======================================
  Files          41       41           
  Lines        6818     6818           
=======================================
  Hits         4735     4735           
  Misses       2083     2083           
Flag Coverage Δ
unittests 69.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +31967 to +31981
"files": {
"type": "object",
"properties": {
"files": {
"description": "The list of files being sent.",
"type": "array",
"items": {
"$ref": "#/components/schemas/MlCopilotFile"
}
}
},
"required": [
"files"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server-to-client file structure has an unnecessary nested files object, creating a files.files path instead of just files. This is inconsistent with the client-to-server structure (lines 31642-31648) which directly contains a files array.

This will cause integration issues where:

  • Client-to-server uses: { files: [MlCopilotFile, ...], type: "files" }
  • Server-to-client uses: { files: { files: [MlCopilotFile, ...] } }

Clients expecting symmetrical structure will fail to access files with response.files[0] when they need response.files.files[0].

Fix: Remove the nested object wrapper:

"files": {
  "description": "The list of files being sent.",
  "type": "array",
  "items": {
    "$ref": "#/components/schemas/MlCopilotFile"
  }
}
Suggested change
"files": {
"type": "object",
"properties": {
"files": {
"description": "The list of files being sent.",
"type": "array",
"items": {
"$ref": "#/components/schemas/MlCopilotFile"
}
}
},
"required": [
"files"
]
}
"files": {
"description": "The list of files being sent.",
"type": "array",
"items": {
"$ref": "#/components/schemas/MlCopilotFile"
}
}

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant