Closed
Conversation
aybarsayan
changed the title
aybarsayan
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| } | ||
| } | ||
| return undefined | ||
| return undefined; |
Member
There was a problem hiding this comment.
Lol. Is this to make a PR?
Author
There was a problem hiding this comment.
Yes 😅 otherwise it doesn't allow me to create a pr so I did the simplest and littest change I possibly can 😅
rflechtner
approved these changes
Feb 18, 2025
Contributor
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
So you're going to open PRs against the new-sdkv1 branch now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I talked to Dudley, he said I needed to make my PRs smaller, so I'm starting from the very beginning. This is exactly the same as the current main, and if you approve this, I will make another small change and proceed from there. (Note: I was unable to send PR because its litterily the main branch, so I did the littlest change and then send a pr)