Draft
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rflechtner
reviewed
Jul 25, 2024
|
|
||
| // Create a connection to a KILT blockchain. | ||
| // let api = await Kilt.connect('wss://peregrine.kilt.io/') | ||
| let api = await Kilt.connect('ws://localhost:9944/') |
Contributor
There was a problem hiding this comment.
maybe just use a descriptive const?
Suggested change
| let api = await Kilt.connect('ws://localhost:9944/') | |
| let api = await Kilt.connect(FULL_NODE_WEB_SOCKET_URL) |
| // The submitter account must have enough funds to cover the deposit costs. | ||
| const submitterMnemonic = | ||
| 'build hill second flame trigger simple rigid cabbage phrase evolve final eight' | ||
| const submitter = Crypto.makeKeypairFromUri(submitterMnemonic, 'sr25519') |
Contributor
There was a problem hiding this comment.
this will change in the next prerelease, so when you port this over to bundle tests, use generateKeypair instead.
| // - `getSubmittable`: Produces transaction that can be submitted to a blockchain node for inclusion, or signed and submitted by an external service. | ||
|
|
||
| // Submit transaction. | ||
| // Note: `submit()` by default, waits for the block to be finalized. This behaviour can be overwritten |
Contributor
There was a problem hiding this comment.
I think the default currently is inBlock - that's something we should discuss again
Contributor
Author
There was a problem hiding this comment.
but the awaitFinalized is true by default, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.