Extension library docs#289
Hidden character warning
Conversation
557bfa4 to
18b9394
Compare
18b9394 to
c2668d1
Compare
ca12d81 to
d05a168
Compare
…hub.com:KILTprotocol/docs into git-checkout-2801-3⃣-kilt-ext-lib-documentation Signed-off-by: Chris Chinchilla <chris@kilt.io> # Conflicts: # docs/develop/01_sdk/04_integrate/04_extension_api.md
d05a168 to
4871cbd
Compare
|
Link checker is breaking and I'm not sure why |
rflechtner
left a comment
There was a problem hiding this comment.
Looks good overall! We should probably try, test, and publish the library before we publish the docs, right?
Also I'm wondering whether it makes sense to introduce a clear distinction between functions intended for application developers and those targeting wallet (extension) implementers
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
…hub.com:KILTprotocol/docs into git-checkout-2801-3⃣-kilt-ext-lib-documentation
0669157 to
a8bbb9b
Compare
|
@rflechtner Made some changes…
Are you saying there's probably more that needs documenting in addition to what's here already? |
Signed-off-by: Chris Chinchilla <chris@kilt.io>
What I'm hinting at is that different functions are meant for use in different environments; |
|
LGTM in general. I'm just wondering why the messaging part is missing. Messaging is crucial for interacting with the extension. Is it not the scope of this PR? |
|
@Ad96el It was never in the docs I took over, I kind of knew that there were methods missing. If you say it's essential, then we can add before merging. |
Signed-off-by: Chris Chinchilla <chris@kilt.io>
|
Seems like I forgot to update the README. 😕 |
|
@Ad96el This read me? https://github.com/KILTprotocol/kilt-extension-api/blob/main/README.md I think we're stuck in a dependency loop as we can't add a link until this is merged and we can't merge this until there's a release. I'm not sure if the extension library is that high-traffic, so we can probably leave it for now? |
fixes KILTProtocol/ticket#2801
Moves Extention library read me to documentation.
Checklist: