Afb plot by minxiyang · Pull Request #6 · JanFSchulte/CIAnalysis

minxiyang · 2019-10-22T15:00:33Z

No description provided.

JanFSchulte · 2019-10-24T20:01:52Z

plotAfb.py

+						#help="use 2017 data and MC.")
+	#parser.add_argument("-2018", "--2018", action="store_true", dest="use2018", default=False,
+                                                #help="use 2018 data and MC.")
+	os.chdir("/home/yang1452/CIAnalysis/plots")


Please do not hardcode something like this here, just add "plots/" to the Canvas.Print() command as in the original plot.py

JanFSchulte · 2019-10-24T20:02:35Z

plotAfb.py

+	os.chdir("/home/yang1452/CIAnalysis/plots")
+	backgrounds = ["Wjets","Other","DrellYan"]
+	PlotlistPos = ["massPlotBBCSPosNoLog","massPlotBECSPosNoLog","massPlotEleBBCSPosNoLog","massPlotEleBECSPosNoLog","massPlotEleEECSPosNoLog"]
+	PlotlistNeg = ["massPlotBBCSNegNoLog","massPlotBECSNegNoLog","massPlotEleBBCSNegNoLog","massPlotEleBECSNegNoLog","massPlotEleEECSNegNoLog"]


do not include the EE category for electrons, we do not use endcap-endcap events in that channel

Are you still including EE here?

No, although I put EE in there, I don't use it in the plot.

JanFSchulte · 2019-10-24T20:03:16Z

plotAfb.py

+	#parser.add_argument("-2018", "--2018", action="store_true", dest="use2018", default=False,
+                                                #help="use 2018 data and MC.")
+	os.chdir("/home/yang1452/CIAnalysis/plots")
+	backgrounds = ["Wjets","Other","DrellYan"]


I think the WJets sample are a reason for the MC plots being to spikey, just remove it. We know that this background is flat in cos theta*

JanFSchulte · 2019-10-24T20:04:49Z

plotAfb.py

+				histTree[flavor][year]["mc"][category].Draw("samehist")
+				legend.Draw()
+				#hCanvas.SetLogx()
+				hCanvas.Print("Distribution of Afb for "+year+" "+flavor+" data "+category+".pdf")


No spaces in file names please, shorten to "Afb_..." and use underscores to separate year, flavor, and category

JanFSchulte · 2019-10-24T20:05:47Z

plotAfb.py

+	plotTree["electron"]["BB"]=[plotsPos[2],plotsNeg[2]]
+	plotTree["electron"]["BE"]=[[plotsPos[3],plotsNeg[3]],[plotsPos[4],plotsNeg[4]]]	
+	for flavor in ["muon","electron"]:
+		bng=binning(flavor)


The binning is way too fine for this plot. Please define a more suitable binning for the AFB plots.

JanFSchulte · 2019-10-24T20:09:32Z

plotAfb.py

+				yMin=0.01
+				legend=ROOT.TLegend(0.1,0.7,0.4,0.98)
+				histTree[flavor][year]["data"][category].SetMarkerStyle(3)
+				histTree[flavor][year]["mc"][category].SetFillColorAlpha(2,0.5)


Please don't use a filled histogram here, just a single line. AFB is just a single number and the filled histogram does not really emphasizes that enough I think.

JanFSchulte · 2019-10-24T20:11:03Z

plotAfb.py

+				xMin=histTree[flavor][year]["mc"][category].GetXaxis().GetXmin()
+				yMax=histTree[flavor][year]["mc"][category].GetBinContent(histTree[flavor][year]["mc"][category].GetMaximumBin())
+				yMin=0.01
+				legend=ROOT.TLegend(0.1,0.7,0.4,0.98)


Please use the legend as it is in plot.py to follow our usual plot style. Also add all the labels like "CMS" and the lumi info and so on from the other plots.

JanFSchulte · 2019-11-04T15:45:34Z

helpers.py



 def binning(channel='muon'):
-	if channel == 'muon':


Please do not break the functionality of other programs! To have a different binning for the AFB plot, please give the function another argument as a switch.

JanFSchulte · 2019-11-04T15:48:08Z

plotAfb.py

+	os.chdir("/home/yang1452/CIAnalysis/plots")
+	backgrounds = ["Wjets","Other","DrellYan"]
+	PlotlistPos = ["massPlotBBCSPosNoLog","massPlotBECSPosNoLog","massPlotEleBBCSPosNoLog","massPlotEleBECSPosNoLog","massPlotEleEECSPosNoLog"]
+	PlotlistNeg = ["massPlotBBCSNegNoLog","massPlotBECSNegNoLog","massPlotEleBBCSNegNoLog","massPlotEleBECSNegNoLog","massPlotEleEECSNegNoLog"]


Are you still including EE here?

JanFSchulte · 2019-11-04T16:03:14Z

plotAfb.py

+                                                                tempDenom=tempDenom.Rebin(len(bng) - 1, 'hist_' + uuid.uuid4().hex, array('d', bng))
+                                                                tempHistAfb=ROOT.TH1D("Afb"+flavor+year+category+dataType,"The distribution of Afb for "+year+" "+flavor+" result",len(binning(flavor))-1  ,array("f",binning(flavor)))
+                                                                tempHistAfb.Divide(tempNom,tempDenom)
+                                                                histTree[flavor][year][dataType][category].append(tempHistAfb.Clone())			


This looks like you are not subtracting the 100k TeV samples, right?

I used 100 kTeV sample.

JanFSchulte · 2020-03-30T18:44:06Z

plotAllMCFlavor.py

+                	el_PUdown_fit=Addstack(el_PUdown)
+                	datamu_fit=Addhist(datamu)
+                	datael_fit=Addhist(datael)
+       			if args.ratio:


Whatever editor you are using is causing issues with the indentation here and at other places throughout the document. Can you use an editor that consistently uses tabs to do the indentation in Python?

JanFSchulte · 2020-03-30T18:50:06Z

plotAllMCFlavor.py

+                        	errmu_fit=Errs_mu_fit[0]["massScale"]**2+(Errs_mu_fit[1]["massScale"]+Errs_mu_fit[2]["massScale"])**2+Errs_mu_fit[0]["resolution"]**2+Errs_mu_fit[1]["resolution"]**2+Errs_mu_fit[2]["resolution"]**2+Errs_mu_fit[0]["ID"]**2+(Errs_mu_fit[1]["ID"]+Errs_mu_fit[2]["ID"])**2
+                	else:
+                        	errmu_fit=Errs_mu_fit[0]["massScale"]**2+(Errs_mu_fit[1]["massScale"]+Errs_mu_fit[2]["massScale"])**2+Errs_mu_fit[0]["resolution"]**2+Errs_mu_fit[1]["resolution"]**2+Errs_mu_fit[2]["resolution"]**2+Errs_mu_fit[0]["ID"]**2+Errs_mu_fit[1]["ID"]**2+Errs_mu_fit[2]["ID"]**2
+                	errel_fit=Errs_el_fit[0]["massScale"]**2+Errs_el_fit[0]["pileUp"]**2+Errs_el_fit[1]["massScale"]**2+Errs_el_fit[1]["pileUp"]**2+Errs_el_fit[2]["massScale"]**2+Errs_el_fit[2]["pileUp"]**2


Are you sure the PU uncertainty and mass scale uncertainty for electrons are uncorrelated between the years?

JanFSchulte · 2020-03-30T18:54:08Z

plotAllMCFlavor.py

-		args.backgrounds = ["Wjets","Other","DrellYan"]
-
+		#args.backgrounds = ["Wjets","Other","DrellYan"]
+		args.backgrounds = ["DrellYan","Other"]


Does that mean you are not taking jets into account at all? I thought we would be removing it only for the fit.

JanFSchulte · 2020-03-30T19:00:42Z

plotAllMCFlavor.py

+			#err=math.sqrt(datamu.GetBinError(i)**2+scale_mu[i-1]+muval**2*fErr**2)/fval
+			err=muval*fErr/fval
+			datamu.SetBinContent(i,muval)
+			datamu.SetBinError(i,err)


Is this from one our tests? It looks like you are are using the fit errors only here.

minxiyang closed this Oct 22, 2019

minxiyang reopened this Oct 22, 2019

JanFSchulte requested changes Oct 24, 2019

View reviewed changes

JanFSchulte reviewed Nov 4, 2019

View reviewed changes

leptonFlavor_plot

ccdc55f

minxiyang force-pushed the master branch from 9cc4d4f to ccdc55f Compare January 31, 2020 01:22

update

d7adec0

JanFSchulte reviewed Mar 30, 2020

View reviewed changes

[Minxi added 2 commits September 29, 2020 17:04

update unfolding

8b7e2b0

code produce the input for the datacard

1799e93

Conversation

minxiyang commented Oct 22, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants