Adds climate, hvac and temperature requests by JagCesar · Pull Request #35 · JagCesar/Tesla-API

JagCesar · 2018-07-15T17:34:30Z

I need these for a feature I'm workin on for Volante.

* Adds empty credentials file so tests compile * Creates EmptyTests target The empty tests are now run on the iOS scheme. Let's keep it like this until we have mocked objects for the tests. The purpose of doing this is to make sure our CI passes the builds.

Updates eu_vehicle and motorized_charge_port, both of these properties are now optional.

houndci-bot · 2018-07-15T17:36:28Z

Tests/Request Tests/SetTemperaturesRequestTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:36:28Z

Tests/Request Tests/SetTemperaturesRequestTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:36:28Z

Tests/Request Tests/SetTemperaturesRequestTests.swift

+                    if result == true {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:36:28Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:36:28Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:36:29Z

Tests/Request Tests/ClimateStateRequestTests.swift

+                case .success(_):
+                    waitExpectation.fulfill()
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:36:29Z

Source/Requests/HVACRequests.swift

+
+public struct HVACRequest: RequestProtocol {
+    public enum HVACState {
+        case on


Identifier Name Violation: Enum element name should be between 3 and 40 characters long: 'on' (identifier_name)

houndci-bot · 2018-07-15T17:36:30Z

Source/Requests/ClimateStateRequest.swift

+                    }
+                    return
+                }
+                let responseDict = response as! [String: [String: Any]]


Force Cast Violation: Force casts should be avoided. (force_cast)

houndci-bot · 2018-07-15T17:36:30Z

Source/Models/ClimateState.swift

+        passengerTempSetting = dict["passenger_temp_setting"] as! Double
+        isAutoConditioningOn = dict["is_auto_conditioning_on"] as! Bool
+        isFrontDefrosterOn = dict["is_front_defroster_on"] as! Bool
+        isRearDefrosterOn = dict["is_rear_defroster_on"] as! Bool


Force Cast Violation: Force casts should be avoided. (force_cast)

houndci-bot · 2018-07-15T17:36:30Z

Source/Models/ClimateState.swift

+        driverTempSetting = dict["driver_temp_setting"] as! Double
+        passengerTempSetting = dict["passenger_temp_setting"] as! Double
+        isAutoConditioningOn = dict["is_auto_conditioning_on"] as! Bool
+        isFrontDefrosterOn = dict["is_front_defroster_on"] as! Bool


Force Cast Violation: Force casts should be avoided. (force_cast)

houndci-bot · 2018-07-15T17:50:38Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:50:39Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:50:39Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:54:04Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:54:04Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:54:05Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:59:10Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T17:59:10Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T17:59:10Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:07:37Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T18:07:37Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:07:37Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:45:43Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T18:45:43Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:45:43Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:51:24Z

Tests/Request Tests/HVACRequestsTests.swift

+                    } else {
+                        XCTFail()
+                    }
+                case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2018-07-15T18:51:24Z

Tests/Request Tests/HVACRequestsTests.swift

+                        XCTFail()
+                    }
+                case .failure(_):
+                    XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

houndci-bot · 2018-07-15T18:51:24Z

Tests/Request Tests/HVACRequestsTests.swift

+                    if result {
+                        waitExpectation.fulfill()
+                    } else {
+                        XCTFail()


XCTFail Message Violation: An XCTFail call should include a description of the assertion. (xctfail_message)

César Pinto Castillo and others added 5 commits March 18, 2018 17:10

Fix so CI only builds (#29)

6610c3e

* Adds empty credentials file so tests compile * Creates EmptyTests target The empty tests are now run on the iOS scheme. Let's keep it like this until we have mocked objects for the tests. The purpose of doing this is to make sure our CI passes the builds.

Tidy up the requests and the base WebRequest

1d1cf9f

Shorten really long line

5371962

Remove unused parameter in callback

d6e6a68

Updates properties on ChargeState

145e69f

Updates eu_vehicle and motorized_charge_port, both of these properties are now optional.

houndci-bot reviewed Jul 15, 2018

View reviewed changes

JagCesar force-pushed the climate-state branch from b96d449 to ea68927 Compare July 15, 2018 17:57

houndci-bot reviewed Jul 15, 2018

View reviewed changes

JagCesar changed the base branch from master to develop July 15, 2018 18:24

JagCesar force-pushed the climate-state branch from 531e5ae to 7b34a98 Compare July 15, 2018 18:43

houndci-bot reviewed Jul 15, 2018

View reviewed changes

JagCesar added 3 commits July 15, 2018 20:49

Add climate state request

d70a185

Add SetTemperaturesRequest

c6b73ad

Add HVAC requests

5cee5f2

JagCesar force-pushed the climate-state branch from 7b34a98 to 5cee5f2 Compare July 15, 2018 18:49

houndci-bot reviewed Jul 15, 2018

View reviewed changes

JagCesar force-pushed the develop branch from 145e69f to a5ed2ec Compare February 22, 2020 02:04

Conversation

JagCesar commented Jul 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants