-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: move hashPlutusData to Data.hashData #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| "@evolution-sdk/evolution": patch | ||
| --- | ||
|
|
||
| Add `Data.hashData()` function for computing blake2b-256 hash of PlutusData. | ||
|
|
||
| This moves the hashing functionality from `utils/Hash.hashPlutusData()` to the Data module for better organization and discoverability. The function computes the datum hash used for inline datums and datum witnesses. | ||
|
|
||
| **Example:** | ||
|
|
||
| ```typescript | ||
| import * as Data from "@evolution-sdk/evolution/Data" | ||
|
|
||
| // Hash a simple integer | ||
| const intHash = Data.hashData(42n) | ||
|
|
||
| // Hash a constructor (e.g., for a custom datum type) | ||
| const constr = new Data.Constr({ index: 0n, fields: [1n, 2n] }) | ||
| const constrHash = Data.hashData(constr) | ||
|
|
||
| // Hash a bytearray | ||
| const bytes = new Uint8Array([0xde, 0xad, 0xbe, 0xef]) | ||
| const bytesHash = Data.hashData(bytes) | ||
|
|
||
| // Hash a map | ||
| const map = new Map<Data.Data, Data.Data>([[1n, 2n]]) | ||
| const mapHash = Data.hashData(map) | ||
| ``` | ||
|
|
||
| **Breaking Change:** `hashPlutusData` has been removed from `utils/Hash`. Use `Data.hashData()` instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Address documentation version changes from v1.0.0 to v2.0.0 appear to be unrelated to the hashPlutusData refactoring described in the PR. While these changes may be correct (as the Address.ts source code uses @SInCE 2.0.0), they are not mentioned in the PR description. Consider whether these changes should be in a separate PR or if the PR description should be updated to mention them.