Skip to content

Set the correct magic field #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
karknu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set the correct magic field #30

karknu wants to merge 1 commit into from
+23 −10

Conversation

@karknu
Copy link
Contributor

@karknu karknu commented Jan 26, 2026 •
edited
Loading

List of changes

  • When one specifies the cardano-network-magic cli option it should set the cardano network's magic not the dmq network's magic.
  • Add dqm-network-magic cli option for setting the dmq network's magic.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Jan 26, 2026
@karknu karknu force-pushed the karknu/cardano-magic branch from db79690 to 2f1f123 Compare January 26, 2026 14:55
@karknu karknu marked this pull request as ready for review January 26, 2026 14:58
@karknu karknu force-pushed the karknu/cardano-magic branch from 2f1f123 to 829ecbb Compare January 27, 2026 07:50
@karknu
Set the correct magic field
02195f7 
When one specifies the cardano-network-magic cli option it should set
the cardano network's magic not the dmq network's magic.
Add cli dmq-network-magic option for setting the dmq network's magic.
@karknu karknu force-pushed the karknu/cardano-magic branch from 829ecbb to 02195f7 Compare January 27, 2026 07:53
@karknu karknu mentioned this pull request Jan 27, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Ouroboros Network
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karknu