Skip to content

Conversation

@nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Jan 27, 2026

Description

Adding EKG metrics for the soft and hard timeouts in the new defensive mempool feature.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@nfrisby nfrisby force-pushed the nfrisby/defensive-mempool-counters branch from 2363a53 to b7b14b0 Compare January 27, 2026 21:32
@nfrisby
Copy link
Contributor Author

nfrisby commented Jan 27, 2026

@mgmeier Does this look like a sufficient way to add new EKG counters?

@nfrisby
Copy link
Contributor Author

nfrisby commented Jan 27, 2026

As of the current tip, cabal build exe:cardano-node lib:cardano-tracer -f+rtview builds clean for me. cabal build all does not, but I assume Pablo just hasn't finished yet on the defensive-mempool branch that this PR targets.

@mgmeier
Copy link
Contributor

mgmeier commented Jan 28, 2026

An additional word about RTView: We are not aware of any active users of that feature, and it's not shipped with our releases of cardano-tracer. The. README states that we only "guarantee it remains buildable and usable in its current state." This means no new features or changes, as we can't sensibly go through UI/UX and e2e testing with RTView, given its design.

The new metrics this PR implements will - without any change to trace-dispatcher or cardano-tracer - be visible both on the Node's internal PrometheusSimple backend and cardano-tracer's Prometheus and EKG endpoints (new tracing) and the regular internal metrics server (legacy tracing).

Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new metrics implementation LGTM! Thank you @nfrisby.

@palas palas force-pushed the defensive-mempool branch from 0dbb8ac to 4a93aa2 Compare January 30, 2026 03:13
@palas palas force-pushed the nfrisby/defensive-mempool-counters branch from f4e457f to 47d5510 Compare January 30, 2026 03:27
@palas palas force-pushed the defensive-mempool branch from 4a93aa2 to 19e2638 Compare January 30, 2026 04:54
@palas palas force-pushed the nfrisby/defensive-mempool-counters branch from 47d5510 to 30ecaad Compare January 30, 2026 04:54
@palas palas force-pushed the defensive-mempool branch from 19e2638 to 5f0d342 Compare January 30, 2026 16:36
@palas palas force-pushed the nfrisby/defensive-mempool-counters branch from 30ecaad to 71b4919 Compare January 30, 2026 16:36
@palas palas changed the title Add counters to Pablo's integration of the defensive mempool Add EKG metrics for soft and hard timeouts and include defensive mempool Jan 30, 2026
@palas palas force-pushed the defensive-mempool branch from 5f0d342 to a1d9efb Compare January 30, 2026 17:46
@palas palas force-pushed the nfrisby/defensive-mempool-counters branch from 71b4919 to 1a782e7 Compare January 30, 2026 18:21
@palas palas self-assigned this Jan 30, 2026
@palas palas marked this pull request as ready for review January 30, 2026 18:25
@palas palas requested a review from a team as a code owner January 30, 2026 18:25
@palas palas force-pushed the defensive-mempool branch from ea332f5 to 611b9ae Compare January 31, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants