You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many benchmark cases for logistic regression are executing something that does not reach convergence within the specified tolerances. This PR adjust the cases used for logistic regression so as to use a more appropriate regularization value for each dataset, and pre-process them in ways that would avoid ending up with features in too different scales.
Before:
After:
Checklist:
Completeness and readability
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have resolved any merge conflicts that might occur with the base branch.
Testing
I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/miniconda/envs/bench-env/lib/python3.11/site-packages/daal4py/mb/gbt_convertors.py", line 546, in get_gbt_model_from_xgboost
base_score = float(xgb_config["learner"]["learner_model_param"]["base_score"])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not convert string to float: '[-2.5816395E0]'
The changes look good to me.
The only question I have: Will it be possible to merge the resulting jsons after these changes with the jsons collected with the current version of the benchmarks? Or they would need to be recollected with the updated version?
The changes look good to me. The only question I have: Will it be possible to merge the resulting jsons after these changes with the jsons collected with the current version of the benchmarks? Or they would need to be recollected with the updated version?
They would be mergeable, but there would be fewer overlapping entries so it wouldn't show comparisons for most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many benchmark cases for logistic regression are executing something that does not reach convergence within the specified tolerances. This PR adjust the cases used for logistic regression so as to use a more appropriate regularization value for each dataset, and pre-process them in ways that would avoid ending up with features in too different scales.
Before:

After:

Checklist:
Completeness and readability
Testing