Skip to content

Conversation

@sukhwinder33445
Copy link

@sukhwinder33445 sukhwinder33445 commented Dec 1, 2025

The following packages do not yet provide support for PHP 8.4/8.5:

  • shardj/zf1-future
  • erusev/parsedown (replaced with parsedown/parsedown)

require: #87

@cla-bot cla-bot bot added the cla/signed label Dec 1, 2025
@sukhwinder33445 sukhwinder33445 marked this pull request as draft December 1, 2025 08:01
Jan-Schuppik added a commit to Icinga/ipl-html that referenced this pull request Dec 1, 2025
BastianLedererIcinga added a commit to Icinga/ipl-web that referenced this pull request Dec 1, 2025
sukhwinder33445 added a commit to Icinga/ipl-validator that referenced this pull request Dec 1, 2025
- Streamline with: Icinga/icinga-php-thirdparty#82
- `psr/http-message` is required for FileValidator and `guzzlehttp/psr7` is required for FileValidatorTest
@sukhwinder33445 sukhwinder33445 self-assigned this Dec 1, 2025
Jan-Schuppik added a commit to Icinga/ipl-html that referenced this pull request Dec 5, 2025
sukhwinder33445 added a commit to Icinga/ipl-validator that referenced this pull request Dec 5, 2025
- Streamline with: Icinga/icinga-php-thirdparty#82
- `guzzlehttp/psr7` is required for FileValidatorTest
sukhwinder33445 added a commit to Icinga/ipl-validator that referenced this pull request Dec 11, 2025
- Streamline with: Icinga/icinga-php-thirdparty#82
- `guzzlehttp/psr7` is required for FileValidatorTest
Jan-Schuppik added a commit to Icinga/ipl-html that referenced this pull request Dec 11, 2025
sukhwinder33445 added a commit to Icinga/ipl-validator that referenced this pull request Dec 12, 2025
- Streamline with: Icinga/icinga-php-thirdparty#82
- `guzzlehttp/psr7` is required for FileValidatorTest
sukhwinder33445 added a commit to Icinga/ipl-validator that referenced this pull request Dec 12, 2025
- Streamline with: Icinga/icinga-php-thirdparty#82
- `guzzlehttp/psr7` is required for FileValidatorTest
lippserd pushed a commit to Icinga/ipl-validator that referenced this pull request Dec 16, 2025
Al2Klimov

This comment was marked as resolved.

Al2Klimov

This comment was marked as resolved.

@sukhwinder33445
Copy link
Author

I have cleaned up the commits. The WIP commits must be removed before merging this branch.

@sukhwinder33445
Copy link
Author

Package react/promise has been upgraded to latest version 3.3.0.

Al2Klimov

This comment was marked as resolved.

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the PR breaks Director again, see #82 (review).

Moreover, I couldn't even cross-check it with own release/snapshot packages without modifying it:

  • git checkout 08d05d0
  • bin/make-release.sh 0.15.0 --no-tag # Says: ERROR: Composer validate failed

I had to comment out the "Composer validate failed" line in bin/make-release.sh:

  • git checkout 08d05d0
  • perl -pi -e 'if (/Composer validate failed/) { s/^/#/ }' bin/make-release.sh
  • bin/make-release.sh 0.15.0 --no-tag
  • git tag v0.15.0

... so that I can test actual packages:

  • git remote add fork git@github.com:Al2Klimov/icinga-php-thirdparty.git
  • git push fork v0.15.0
  • git tag -d v0.15.0
  • git checkout .
  • git checkout -
  • git branch -D stable/0.15.0

@Al2Klimov
Copy link
Member

My last review still applies. Either fix that or do this:

--- a/bin/make-release.sh
+++ b/bin/make-release.sh
@@ -42 +42 @@ git commit -m "Version v$VERSION"
-composer validate --no-check-all --strict || fail "Composer validate failed"
+composer validate --no-check-all || fail "Composer validate failed"

@Al2Klimov
Copy link
Member

* I mean not (necessarily) now, but before merging this PR.

My point is just, if we merge it as-is, both snapshots and releases would break. As discussed with @lippserd offline, that's exactly what we won't do. Instead, we must make a decision (one nice day? CW45?) what we do with this:

[fedora@aklimov-fedora icinga-php-thirdparty]$ composer validate --no-check-all --strict
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- The package "erusev/parsedown" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
- The package "shardj/zf1-future" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
[fedora@aklimov-fedora icinga-php-thirdparty]$ echo $?
1
[fedora@aklimov-fedora icinga-php-thirdparty]$

Either, if we need those commit-refs in the long run, we remove --strict – but that's not the preferred option. Ideally those ref-ed commits get upstreamed and we won't need commit-ref anymore.

lippserd and others added 3 commits January 23, 2026 11:55
Ensure dependency resolution matches minimum supported PHP version (8.2). This
prevents possible lockfile inconsistencies on diverse OS environments (Linux,
macOS) with varying PHP versions, guaranteeing reliable installs everywhere we
deploy.
This is a replacement for abandoned `clue/block-react`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants