-
Notifications
You must be signed in to change notification settings - Fork 4
Support PHP 8.5 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support PHP 8.5 #82
Conversation
- Streamline with: Icinga/icinga-php-thirdparty#82 - `psr/http-message` is required for FileValidator and `guzzlehttp/psr7` is required for FileValidatorTest
ec719d2 to
b60bf88
Compare
- Streamline with: Icinga/icinga-php-thirdparty#82 - `guzzlehttp/psr7` is required for FileValidatorTest
- Streamline with: Icinga/icinga-php-thirdparty#82 - `guzzlehttp/psr7` is required for FileValidatorTest
- Streamline with: Icinga/icinga-php-thirdparty#82 - `guzzlehttp/psr7` is required for FileValidatorTest
- Streamline with: Icinga/icinga-php-thirdparty#82 - `guzzlehttp/psr7` is required for FileValidatorTest
Streamline with Icinga/icinga-php-thirdparty#82
95acc02 to
f4e7375
Compare
d0f6c6b to
83415ec
Compare
cecbaab to
0cb1f19
Compare
|
I have cleaned up the commits. The WIP commits must be removed before merging this branch. |
|
Package |
0cb1f19 to
8e3e897
Compare
8e3e897 to
08d05d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the PR breaks Director again, see #82 (review).
Moreover, I couldn't even cross-check it with own release/snapshot packages without modifying it:
- git checkout 08d05d0
- bin/make-release.sh 0.15.0 --no-tag # Says: ERROR: Composer validate failed
I had to comment out the "Composer validate failed" line in bin/make-release.sh:
- git checkout 08d05d0
perl -pi -e 'if (/Composer validate failed/) { s/^/#/ }' bin/make-release.sh- bin/make-release.sh 0.15.0 --no-tag
- git tag v0.15.0
... so that I can test actual packages:
- git remote add fork git@github.com:Al2Klimov/icinga-php-thirdparty.git
- git push fork v0.15.0
- git tag -d v0.15.0
- git checkout .
- git checkout -
- git branch -D stable/0.15.0
7ef92cd to
911f231
Compare
9a12a41 to
9a0f8ba
Compare
|
My last review still applies. Either fix that or do this: --- a/bin/make-release.sh
+++ b/bin/make-release.sh
@@ -42 +42 @@ git commit -m "Version v$VERSION"
-composer validate --no-check-all --strict || fail "Composer validate failed"
+composer validate --no-check-all || fail "Composer validate failed" |
|
* I mean not (necessarily) now, but before merging this PR. My point is just, if we merge it as-is, both snapshots and releases would break. As discussed with @lippserd offline, that's exactly what we won't do. Instead, we must make a decision (one nice day? CW45?) what we do with this: Either, if we need those commit-refs in the long run, we remove --strict – but that's not the preferred option. Ideally those ref-ed commits get upstreamed and we won't need commit-ref anymore. |
Ensure dependency resolution matches minimum supported PHP version (8.2). This prevents possible lockfile inconsistencies on diverse OS environments (Linux, macOS) with varying PHP versions, guaranteeing reliable installs everywhere we deploy.
This is a replacement for abandoned `clue/block-react`.
9a0f8ba to
f64eff3
Compare
f64eff3 to
b844df3
Compare
The following packages do not yet provide support for PHP 8.4/8.5:
shardj/zf1-futureerusev/parsedown(replaced withparsedown/parsedown)require: #87