You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mtfishman If I resolve the merge conflicts can this be merged?
I think it seems reasonable to have this kind of functionality, though I'm starting to worry about putting too much functionality and too many keyword arguments into the dmrg function.
I think a design I would prefer would be to rename the current dmrg(args...; kwargs...) function to generic_dmrg(f, args...; kwargs...), where the first argument f is a function that is called for the local update, so for dmrg it would be a function that calls eigsolve. Then, we could define realdmrg where f is a function that calls realeigsolve.
For some context, providing flexibility for different local solver backends (in this case, eigsolve vs. realeigsolve) is one of the motivations behind alternating_update function in this package along with the next-generation "sweep solving" framework we're developing in ITensorNetworks.jl, where the design allows for specifying a custom local update function along with other customizability (like changing the number of sites that will be updated, the order of updating the sites, how the gauge center is moved, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving from ITensor/ITensors.jl#1546